Enrich User-Agent Header in gRPC Metadata to indicate Client or Worker as caller #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunchuWang
changed the title
cgillum
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the user agent string generation for the Durable Task SDK by including the component type (e.g., Client or Worker) in the string. Additionally, it updates imports in relevant files to ensure proper usage of namespaces. Below are the most significant changes:
User Agent String Improvements:
GetUserAgentmethod inDurableTaskUserAgentUtilto include acomponentTypeparameter, allowing the user agent string to specify whether it pertains to a Client or Worker. (src/Shared/AzureManaged/DurableTaskVersionUtil.cs, src/Shared/AzureManaged/DurableTaskVersionUtil.csL24-R30)GetUserAgentinDurableTaskSchedulerClientOptionsandDurableTaskSchedulerWorkerOptionsto pass the appropriate component type (DurableTaskClientorDurableTaskWorker). (src/Client/AzureManaged/DurableTaskSchedulerClientOptions.cs, [1];src/Worker/AzureManaged/DurableTaskSchedulerWorkerOptions.cs, [2]Namespace Updates:
Microsoft.DurableTask.ClientandMicrosoft.DurableTask.Worker.HostinginDurableTaskSchedulerClientOptionsandDurableTaskSchedulerWorkerOptions, respectively, to ensure proper functionality. (src/Client/AzureManaged/DurableTaskSchedulerClientOptions.cs, [1];src/Worker/AzureManaged/DurableTaskSchedulerWorkerOptions.cs, [2]